feat: editor syntax tinting + framing parity #14

Merged

fiatcode merged 11 commits from feat/editor-syntax-tinting into main

2026-06-17 13:51:09 +07:00

fiatcode commented

2026-06-17 13:49:07 +07:00

Owner

Polishes the in-app markdown editor so it feels like the same app as the Glamour read view.

What changed

Framing parity — the editor now occupies the same box as the read view: a 2-column left inset (matching Glamour's document margin) and a 1-row top margin (matching its leading blank line). Text no longer jumps left/up on entering edit mode.
Hybrid syntax tinting — live colorization of the raw buffer: headings (bold), blockquotes + code-fence delimiters (faint), task markers (TODO/DOING/… colored to match the read view + todos dashboard), and [[wiki-links]] (link color). The cursor's current row is left raw — a deliberate "reveal source where you edit" affordance.

How it works

A pure string → string decorator (internal/views/edit_tint.go) post-processes textarea.View() output: it tints every escape-free row and skips rows that already carry ANSI (the cursor row's CursorLine background + end-of-buffer filler). The textarea's empty-but-styled prompt was neutralized so non-cursor rows stay escape-free — without that, the prompt put an escape on every row and suppressed all tinting.

Reuses theme.go's colorHighlight and mirrors internal/render's task-marker palette locally (the documented convention — not a shared package).

Scope

Render-layer only; internal/edit/ stays the sole disk writer. Explicit non-goals (v1): code-block body tinting, inline emphasis/inline-code tinting, tinting the cursor row.

Testing

Unit tests for the tinting core + an integration test asserting tinting reaches View(); editor goldens regenerated (run under NO_COLOR, so they cover the inset/margin). go vet ./... && go test ./... green.

Design spec + plan: docs/superpowers/specs/2026-06-17-editor-syntax-tinting-design.md, docs/superpowers/plans/2026-06-17-editor-syntax-tinting.md.

Polishes the in-app markdown editor so it feels like the same app as the Glamour read view. ## What changed - **Framing parity** — the editor now occupies the same box as the read view: a 2-column left inset (matching Glamour's document margin) and a 1-row top margin (matching its leading blank line). Text no longer jumps left/up on entering edit mode. - **Hybrid syntax tinting** — live colorization of the raw buffer: headings (bold), blockquotes + code-fence delimiters (faint), task markers (TODO/DOING/… colored to match the read view + todos dashboard), and `[[wiki-links]]` (link color). The cursor's current row is left raw — a deliberate "reveal source where you edit" affordance. ## How it works A pure `string → string` decorator (`internal/views/edit_tint.go`) post-processes `textarea.View()` output: it tints every escape-free row and skips rows that already carry ANSI (the cursor row's CursorLine background + end-of-buffer filler). The textarea's empty-but-styled prompt was neutralized so non-cursor rows stay escape-free — without that, the prompt put an escape on every row and suppressed all tinting. Reuses `theme.go`'s `colorHighlight` and mirrors `internal/render`'s task-marker palette locally (the documented convention — not a shared package). ## Scope Render-layer only; `internal/edit/` stays the sole disk writer. Explicit non-goals (v1): code-block *body* tinting, inline emphasis/inline-code tinting, tinting the cursor row. ## Testing Unit tests for the tinting core + an integration test asserting tinting reaches `View()`; editor goldens regenerated (run under NO_COLOR, so they cover the inset/margin). `go vet ./... && go test ./...` green. Design spec + plan: `docs/superpowers/specs/2026-06-17-editor-syntax-tinting-design.md`, `docs/superpowers/plans/2026-06-17-editor-syntax-tinting.md`.

fiatcode added 11 commits

2026-06-17 13:49:07 +07:00

docs: design spec for editor syntax tinting + framing parity 88fd243d4d

docs: implementation plan for editor syntax tinting 9d2ccb9372

feat: inset in-app editor to match read-view left margin 84155ac68a

feat: pure markdown row-tinting module for the editor 6e6855cd78

test: harden editor-tint tests; tidy termenv as direct dep 36a2c0475a

test: drop now-unused hasSGR helper from editor-tint tests bb33cbbda5

feat: tint markdown syntax live in the in-app editor 7530097dee

fix: neutralize editor prompt style so tintView actually tints 9f0bea4930

docs: note editor syntax tinting + inset in AGENTS.md 09f52560b4

test: guard inset test env; clarify editor link-tint comment b3fe0e53d7